01 15 added support for supported features in toml by js-goupil · Pull Request #6765 · Shopify/cli

js-goupil · 2026-01-15T17:35:56Z

Closes https://github.com/shop/issues-retail/issues/22868

WHY are these changes introduced?

This adds the ability to specify in the toml, whether or not an extension supports offline_mode. This is a new feature for POS Extensions. The backend is already wired up to support this.

WHAT is this pull request doing?

Parses the toml extensions.supported_features offline_mode boolean to include its value in the deploy config.

How to test your changes?

Check out this branch.
Make sure your extension locally has this in the toml:

[extensions.supported_features]
  offline_mode = true

run pnpm shopify app deploy --path [PATH_TO_APP]
Go to your shop's graphiql and query the extensions endpoint. Make sure you query the config and supportedFeatures fields on the Extension object.

Post-release steps

Update POS/config documentation

Measuring impact

How do we know this change was effective? Please choose one:

n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
Existing analytics will cater for this addition
PR includes analytics changes to measure impact

Checklist

I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've considered possible documentation changes

github-actions · 2026-01-15T18:20:45Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	79.5% (+0.28% 🔼)	14349/18048
🟡	Branches	73.78% (+0.67% 🔼)	7092/9612
🟡	Functions	79.64% (+0.27% 🔼)	3666/4603
🟡	Lines	79.87% (+0.28% 🔼)	13566/16986

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / admin-as-app.ts	100%	100%	100%	100%
🟢	`...` / metafield_definitions.ts	100%	100%	100%	100%
🟢	`...` / metaobject_definitions.ts	100%	100%	100%	100%
🟢	`...` / bulk-operation-cancel.ts	100%	100%	100%	100%
🟢	`...` / bulk-operation-run-mutation.ts	100%	100%	100%	100%
🟢	`...` / bulk-operation-run-query.ts	100%	100%	100%	100%
🟢	`...` / get-bulk-operation-by-id.ts	100%	100%	100%	100%
🟢	`...` / list-bulk-operations.ts	100%	100%	100%	100%
🟢	`...` / staged-uploads-create.ts	100%	100%	100%	100%
🟢	`...` / fetch_store_by_domain.ts	100%	100%	100%	100%
🔴	`...` / import-custom-data-definitions.ts	0%	100%	0%	0%
🔴	`...` / cancel.ts	0%	100%	0%	0%
🔴	`...` / execute.ts	0%	0%	0%	0%
🔴	`...` / status.ts	0%	0%	0%	0%
🔴	`...` / pull.ts	0%	100%	0%	0%
🟡	`...` / execute-operation.ts	75%	50%	100%	75%
🔴	`...` / pull.ts	0%	0%	0%	0%
🟢	`...` / bulk-operation-status.ts	96.55%	92.11%	100%	100%
🟢	`...` / cancel-bulk-operation.ts	100%	100%	100%	100%
🟢	`...` / constants.ts	100%	100%	100%	100%
🟢	`...` / download-bulk-operation-results.ts	100%	100%	100%	100%
🟢	`...` / execute-bulk-operation.ts	86.76%	83.67%	100%	88.06%
🟢	`...` / format-bulk-operation-status.ts	100%	100%	100%	100%
🟢	`...` / run-mutation.ts	100%	100%	100%	100%
🟢	`...` / run-query.ts	100%	100%	100%	100%
🟡	`...` / stage-file.ts	73.53%	62.5%	85.71%	72.73%
🟢	`...` / watch-bulk-operation.ts	100%	94.74%	100%	100%
🟢	`...` / utilities.ts	100%	100%	100%	100%
🟢	`...` / declarative-definitions.ts	98.54%	93.18%	100%	98.51%
🟢	`...` / common.ts	97.62%	95%	100%	97.06%
🟢	`...` / execute-command-helpers.ts	100%	100%	100%	100%
🟢	`...` / file-formatter.ts	100%	100%	100%	100%
🔴	`...` / promiseWithResolvers.ts	33.33%	50%	50%	33.33%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / execute.ts	0%	0% (-100% 🔻)	0%	0%
🟢	`...` / loader.ts	94.06% (+0.2% 🔼)	86.41% (-0.42% 🔻)	97.17% (+0.11% 🔼)	94.85% (+0.18% 🔼)
🟢	`...` / extension-instance.ts	84.8% (+0.23% 🔼)	77.6% (-0.91% 🔻)	92.06% (+0.13% 🔼)	85.11% (+0.24% 🔼)
🟡	`...` / specification.ts	69.64% (+0.55% 🔼)	75.61% (+2.44% 🔼)	76.47% (-1.31% 🔻)	69.39% (+0.64% 🔼)
🟢	`...` / ui_extension.ts	87.9% (-6.93% 🔻)	77.19% (-4.06% 🔻)	85.19% (-14.81% 🔻)	90.07% (-6.39% 🔻)
🟢	`...` / store-context.ts	100%	82.35% (-0.98% 🔻)	100%	100%
🟢	`...` / Logs.tsx	90%	90.91% (-5.97% 🔻)	100%	90%
🟢	`...` / fetch.ts	84.21% (+0.88% 🔼)	82.35% (-0.98% 🔻)	75%	85.29% (+1.42% 🔼)
🟢	`...` / app-event-watcher-handler.ts	86.36% (-4.11% 🔻)	75%	86.67%	85.71% (-5.19% 🔻)
🔴	`...` / server.ts	1.23% (-0.02% 🔻)	0%	0%	1.3% (-0.02% 🔻)
🟢	`...` / bundle.ts	93.22%	63.33% (-3.33% 🔻)	94.12% (+5.88% 🔼)	96.3%
🟢	`...` / developer-platform-client.ts	84.62% (-1.5% 🔻)	71.43% (+0.84% 🔼)	81.82% (+1.82% 🔼)	93.75% (+0.42% 🔼)
🔴	`...` / http-reverse-proxy.ts	58.97% (-4.91% 🔻)	37.04% (-2.96% 🔻)	58.33% (-5.3% 🔻)	59.46% (-5.25% 🔻)
🔴	`...` / app-management-client.ts	53.69% (-0.16% 🔻)	47.47%	50% (-0.45% 🔻)	52.53% (-0.17% 🔻)
🟢	`...` / api.ts	87.07% (-0.43% 🔻)	76.71% (-0.1% 🔻)	100%	86.49% (-0.43% 🔻)
🟢	`...` / device-authorization.ts	88.24% (-0.83% 🔻)	76.47% (-2.94% 🔻)	100%	88.24% (-0.83% 🔻)
🟢	`...` / SingleTask.tsx	84.21% (-15.79% 🔻)	50% (-50% 🔻)	80% (-20% 🔻)	84.21% (-15.79% 🔻)
🔴	`...` / environment.ts	35% (-5% 🔻)	41.18%	40% (-10% 🔻)	36.84% (-5.26% 🔻)
🔴	`...` / ui.tsx	50.82% (-0.79% 🔻)	42.86% (-5.53% 🔻)	54.55% (+1.42% 🔼)	50% (-0.82% 🔻)
🟢	`...` / console.ts	81.82% (+15.15% 🔼)	75% (-25% 🔻)	100% (+33.33% 🔼)	81.82% (+15.15% 🔼)
🟢	`...` / init.ts	88% (-0.89% 🔻)	71.43% (+4.76% 🔼)	86.67% (+4.85% 🔼)	88% (-0.89% 🔻)
🟢	`...` / storefront-renderer.ts	90.2% (-0.54% 🔻)	78.95%	81.82% (-1.52% 🔻)	90.2% (-0.54% 🔻)
🟡	`...` / theme-polling.ts	67.12% (-0.93% 🔻)	68.75%	78.57%	66.67% (-0.98% 🔻)

Test suite run success

3676 tests passing in 1431 suites.

Report generated by 🧪jest coverage report action from f903c47

js-goupil · 2026-01-19T16:29:14Z

packages/app/src/cli/services/dev/extension/payload.ts

        },
      },
+      supportedFeatures: {
+        supportsOffline: extension.configuration.supported_features?.offline_mode ?? false,


dev payloads use camel casing, unlike the deployed configs, which use snake case.

packages/app/src/cli/services/dev/extension/payload.test.ts

packages/app/src/cli/models/extensions/specifications/ui_extension.test.ts

vividviolet

Looks great!

alfonso-noriega

LGTM!

aaronschubert0

Exciting addition, thanks!

js-goupil force-pushed the 01-15-added_support_for_supported_features_in_toml branch from fe39235 to 71f5db9 Compare January 15, 2026 18:08

js-goupil marked this pull request as ready for review January 19, 2026 16:27

js-goupil requested a review from a team as a code owner January 19, 2026 16:27

js-goupil commented Jan 19, 2026

View reviewed changes

js-goupil requested review from aaronschubert0, andy-chhuon and vividviolet January 19, 2026 16:34

js-goupil force-pushed the 01-15-added_support_for_supported_features_in_toml branch 3 times, most recently from 282c402 to 861716b Compare January 19, 2026 18:42

vividviolet reviewed Jan 19, 2026

View reviewed changes

packages/app/src/cli/services/dev/extension/payload.test.ts Show resolved Hide resolved

packages/app/src/cli/models/extensions/specifications/ui_extension.test.ts Show resolved Hide resolved

Added support for supported features in toml

f903c47

js-goupil force-pushed the 01-15-added_support_for_supported_features_in_toml branch from 861716b to f903c47 Compare January 20, 2026 18:18

js-goupil requested a review from vividviolet January 20, 2026 18:18

vividviolet approved these changes Jan 20, 2026

View reviewed changes

js-goupil requested a review from alfonso-noriega January 20, 2026 20:49

alfonso-noriega approved these changes Jan 21, 2026

View reviewed changes

aaronschubert0 approved these changes Jan 21, 2026

View reviewed changes

js-goupil added this pull request to the merge queue Jan 21, 2026

Merged via the queue into main with commit df89f93 Jan 21, 2026
25 checks passed

js-goupil deleted the 01-15-added_support_for_supported_features_in_toml branch January 21, 2026 15:20

phyllis-sy-wu mentioned this pull request Feb 2, 2026

create a new RELEASE_NOTES/3.90.md file #6809

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

01 15 added support for supported features in toml#6765

01 15 added support for supported features in toml#6765
js-goupil merged 1 commit intomainfrom
01-15-added_support_for_supported_features_in_toml

js-goupil commented Jan 15, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

js-goupil Jan 19, 2026

Uh oh!

Uh oh!

Uh oh!

vividviolet left a comment

Uh oh!

alfonso-noriega left a comment

Uh oh!

aaronschubert0 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

js-goupil commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

Checklist

Uh oh!

github-actions bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Test suite run success

Uh oh!

js-goupil Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vividviolet left a comment

Choose a reason for hiding this comment

Uh oh!

alfonso-noriega left a comment

Choose a reason for hiding this comment

Uh oh!

aaronschubert0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

js-goupil commented Jan 15, 2026 •

edited

Loading

github-actions bot commented Jan 15, 2026 •

edited

Loading